Skip to content

create email editor#105

Open
piersolh wants to merge 1 commit intomainfrom
piersol-email-comms
Open

create email editor#105
piersolh wants to merge 1 commit intomainfrom
piersol-email-comms

Conversation

@piersolh
Copy link
Copy Markdown
Contributor

@piersolh piersolh commented Apr 5, 2026

Description

Briefly describe the changes and why they are needed.
implement #94

  • create email text editor
  • create email text preview
  • generate payload after saving draft or send button
    page located at: /sidebar-test

Changes Made

  • Backend changes
  • Frontend changes
  • Database schema changes
  • Configuration updates
  • Other

Testing & Verification

  • Unit tests pass -> skipped unit tests, needs design review
  • Manual testing completed
  • No breaking changes

Verification Steps:

  • tested creating emails and styling them

Screenshots (if relevant)

Screenshot 2026-04-05 at 5 51 05 PM Screenshot 2026-04-05 at 5 51 41 PM Screenshot 2026-04-05 at 5 51 53 PM

Future Improvements/Notes

  1. design review
  2. implement Email Communications (Backend, SES) Part 2 - don't start until Part 1 complete. #95

Related Issues

Closes #94

@piersolh piersolh marked this pull request as ready for review April 5, 2026 21:57

export default {
module.exports = {
content: [
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to change the config so that the tailwind would render the styling in the email editor correctly

@piersolh piersolh changed the title create webpage create email editor Apr 5, 2026
@thaninbew thaninbew self-requested a review April 11, 2026 22:10
Copy link
Copy Markdown
Collaborator

@thaninbew thaninbew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

  • is there no way to keep the tailwind config back where it was, that was the more modern syntax. I believe u can still add typography plugin without changing the entire file to an older format. correct me if i am wrong!
  • I like the idea of the email signature customization and what you added. i believe we can present it to design.
  • I see that you used some shadcn components but really the ticket explicitly requires using our shared design system. Your UI elements are built from scratch, so I'd recommend to refactor the form inputs, buttons, tabs, etc to use our existing shared components. This will also make everything look more alike to the design.
  • I'd say try to stick closer to design on figma with the font, colors, and looks. For example, some buttons in ur ticket have an underglow, or the formatting tools section looks really different.
  • The email preview part was like a placeholder design by the designers whcih is why it's so blue. as designers build it out id say try to mimic the barebones design as we wont know fully what it'd look like in the future.

Thanks again for your work! DM if questions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email Communications HTML editor interface (frontend) Part 1

2 participants