Open
Conversation
piersolh
commented
Apr 5, 2026
|
|
||
| export default { | ||
| module.exports = { | ||
| content: [ |
Contributor
Author
There was a problem hiding this comment.
had to change the config so that the tailwind would render the styling in the email editor correctly
thaninbew
requested changes
Apr 11, 2026
Collaborator
thaninbew
left a comment
There was a problem hiding this comment.
Thank you for your PR!
- is there no way to keep the tailwind config back where it was, that was the more modern syntax. I believe u can still add typography plugin without changing the entire file to an older format. correct me if i am wrong!
- I like the idea of the email signature customization and what you added. i believe we can present it to design.
- I see that you used some shadcn components but really the ticket explicitly requires using our shared design system. Your UI elements are built from scratch, so I'd recommend to refactor the form inputs, buttons, tabs, etc to use our existing shared components. This will also make everything look more alike to the design.
- I'd say try to stick closer to design on figma with the font, colors, and looks. For example, some buttons in ur ticket have an underglow, or the formatting tools section looks really different.
- The email preview part was like a placeholder design by the designers whcih is why it's so blue. as designers build it out id say try to mimic the barebones design as we wont know fully what it'd look like in the future.
Thanks again for your work! DM if questions :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Briefly describe the changes and why they are needed.
implement #94
page located at: /sidebar-test
Changes Made
Testing & Verification
Verification Steps:
Screenshots (if relevant)
Future Improvements/Notes
Related Issues
Closes #94